podman icon indicating copy to clipboard operation
podman copied to clipboard

machine: Add provider detection API

Open jakecorrenti opened this issue 10 months ago • 4 comments

Extends the pkg/machine/provider package to add an API which includes provider detection based on the host operating system.

Does this PR introduce a user-facing change?

None

jakecorrenti avatar Apr 23 '24 20:04 jakecorrenti

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakecorrenti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Apr 23 '24 20:04 openshift-ci[bot]

Ephemeral COPR build failed. @containers/packit-build please check.

Ephemeral COPR build failed. @containers/packit-build please check.

Code LGTM

mheon avatar Apr 24 '24 14:04 mheon

im going to merge but @jakecorrenti , perhaps you can consider a semver update

baude avatar May 07 '24 14:05 baude

/lgtm

baude avatar May 07 '24 14:05 baude

Regarding macos version checks, you could also add a check to the installer, something like https://github.com/cfergeau/podman/commit/f5c5f4a5e368243417773b56889b2627802eac01 which I haven't tested.

cfergeau avatar May 07 '24 14:05 cfergeau