podman
podman copied to clipboard
machine: Add provider detection API
Extends the pkg/machine/provider
package to add an API which includes provider detection based on the host operating system.
Does this PR introduce a user-facing change?
None
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jakecorrenti
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [jakecorrenti]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
Ephemeral COPR build failed. @containers/packit-build please check.
Ephemeral COPR build failed. @containers/packit-build please check.
Code LGTM
im going to merge but @jakecorrenti , perhaps you can consider a semver update
/lgtm
Regarding macos version checks, you could also add a check to the installer, something like https://github.com/cfergeau/podman/commit/f5c5f4a5e368243417773b56889b2627802eac01 which I haven't tested.