podman icon indicating copy to clipboard operation
podman copied to clipboard

Vendor in containers/(storage, common)

Open rhatdan opened this issue 1 year ago • 8 comments
trafficstars

Does this PR introduce a user-facing change?

None

rhatdan avatar Apr 23 '24 13:04 rhatdan

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Apr 23 '24 13:04 openshift-ci[bot]

@edsantiago a lot of the fixes for composefs from containers/storage by @giuseppe should be in this PR.

rhatdan avatar Apr 23 '24 13:04 rhatdan

we need https://github.com/containers/podman/pull/22465 first to bump go

Luap99 avatar Apr 23 '24 13:04 Luap99

Please revendor once https://github.com/containers/storage/pull/1904 merges

edsantiago avatar Apr 23 '24 14:04 edsantiago

Ephemeral COPR build failed. @containers/packit-build please check.

Also, "thinpool" seems to be gone in latest c-storage, and now podman barfs:

WARN[0000] Failed to decode the keys ["storage.options.thinpool"] from "/usr/share/containers/storage.conf"

Not sure if this needs to be fixed in podman-land or something-else-land.

edsantiago avatar Apr 23 '24 15:04 edsantiago

You'll also need to wait for a fix for https://github.com/containers/storage/issues/1909

edsantiago avatar Apr 23 '24 23:04 edsantiago

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot avatar Apr 27 '24 16:04 openshift-merge-robot

Not needed after https://github.com/containers/podman/pull/22638 anymore

vrothberg avatar May 13 '24 12:05 vrothberg