podman icon indicating copy to clipboard operation
podman copied to clipboard

ExitWithError() - continue tightening

Open edsantiago opened this issue 1 year ago • 4 comments

Followup to #22270 : wherever possible/practical, extend command error checks to include explicit exit status codes and error strings.

A small number of tests were broken, as in, not actually testing what they claimed to be testing. I've done my best to fix those.

Signed-off-by: Ed Santiago [email protected]

None

edsantiago avatar Apr 11 '24 14:04 edsantiago

Ephemeral COPR build failed. @containers/packit-build please check.

@containers/podman-maintainers should I split this into smaller chunks?

edsantiago avatar Apr 30 '24 13:04 edsantiago

@containers/podman-maintainers should I split this into smaller chunks?

I am fine with it, I have now reviewed everything anyway. Just noticed the one blocker above.

Luap99 avatar Apr 30 '24 14:04 Luap99

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [Luap99,edsantiago]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Apr 30 '24 16:04 openshift-ci[bot]

/lgtm

mheon avatar May 08 '24 17:05 mheon