Container.wait does not respect timeout

[yaqwsx]

The method Container.wait does not raises ReadTimeoutError. By briefly looking at the source code the implementation does not use the parameter timeout.

[rhatdan]

Care to open a PR to fix this?

[yaqwsx]

I am sorry if my report sounded disrespectful - that was not my intention. I am not a native speaker, so I might not get the tone right. Before digging into the code and getting familiar with the project, I want confirmation from a developer that this is indeed the fact and I do not miss something.

[rhatdan]

I did not read this as disrespectful. I would think that Timeout is definitely something the python code should handle and send to the service.

[jwhonce]

@yaqwsx timeout requires an update the the libpod API. I accepted the input so docker-py scripts did not need to be changed but currently I have no way to communicate it with the service. I'll update the docstring to reflect this.

• https://docs.podman.io/en/latest/_static/api.html#operation/ContainerWaitLibpod
• https://github.com/containers/podman-py/blob/master/podman/domain/containers.py#L471