podman-py icon indicating copy to clipboard operation
podman-py copied to clipboard

Add ssh env variables to tox testenv

Open inknos opened this issue 1 year ago • 2 comments

For users who have a ssh key protected by passphrase tests can hang and fail on 'Enter passphrase for key' if the correct ssh agent env variable is not set in tox.

inknos avatar Jun 19 '24 14:06 inknos

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: inknos Once this PR has been reviewed and has the lgtm label, please assign rhatdan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jun 19 '24 14:06 openshift-ci[bot]

/packit build

inknos avatar Jul 01 '24 07:07 inknos

@inknos It looks like your change impacted how ssh connectiions are being parsed. Or did the podman API server change?

jwhonce avatar Jul 08 '24 22:07 jwhonce

no, there must be something wrong. I'll close the PR for now and try to look more in my local env. This looks like being a fix for me only :/

inknos avatar Jul 16 '24 10:07 inknos