podman-py
podman-py copied to clipboard
Include py.typed marker file.
I'm using this package in codebases checked with common static type checking tools, such as mypy
. Unfortunately, it will error:
error: Skipping analyzing "podman": module is installed, but missing library stubs or py.typed marker [import]
This was already apparent in https://github.com/containers/podman-py/issues/293. Including this file would at least enable checking against the many type hints that are already a part of this library and would help massively.
@jnsnow PTAL, TIA
Any updates on this? This is only adding one single, entirely empty marker file; is this connected to any considerations?
Thank you @jonded94! Can you please rebase with upstream and sign your commit and repush, I think that should help fix the DCO and gating failure.
Changes LGTM
Did a rebase and a force repush, with a signed commit (which also shows to be verified in Github), but unfortunately that DCO job still fails?
I believe DCO is failing because your commit doesn't have the Signed off by...
line it. Can you please ensure git commit -s --amend
adds that for you and then repush.
Tests seem to run through now, thanks for your help!
/approve /lgtm Thanks @jonded94
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jonded94, rhatdan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [rhatdan]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment