podman-py icon indicating copy to clipboard operation
podman-py copied to clipboard

Include py.typed marker file.

Open jonded94 opened this issue 11 months ago • 2 comments

I'm using this package in codebases checked with common static type checking tools, such as mypy. Unfortunately, it will error:

error: Skipping analyzing "podman": module is installed, but missing library stubs or py.typed marker  [import]

This was already apparent in https://github.com/containers/podman-py/issues/293. Including this file would at least enable checking against the many type hints that are already a part of this library and would help massively.

jonded94 avatar Mar 13 '24 12:03 jonded94

@jnsnow PTAL, TIA

jwhonce avatar Mar 13 '24 15:03 jwhonce

Any updates on this? This is only adding one single, entirely empty marker file; is this connected to any considerations?

jonded94 avatar Apr 03 '24 10:04 jonded94

Thank you @jonded94! Can you please rebase with upstream and sign your commit and repush, I think that should help fix the DCO and gating failure.

Changes LGTM

umohnani8 avatar Apr 04 '24 13:04 umohnani8

Did a rebase and a force repush, with a signed commit (which also shows to be verified in Github), but unfortunately that DCO job still fails?

jonded94 avatar Apr 05 '24 10:04 jonded94

I believe DCO is failing because your commit doesn't have the Signed off by... line it. Can you please ensure git commit -s --amend adds that for you and then repush.

umohnani8 avatar Apr 05 '24 13:04 umohnani8

Tests seem to run through now, thanks for your help!

jonded94 avatar Apr 06 '24 19:04 jonded94

/approve /lgtm Thanks @jonded94

rhatdan avatar Apr 08 '24 13:04 rhatdan

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonded94, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Apr 08 '24 13:04 openshift-ci[bot]