podman-py Support passing of interval and condition in podman wait calls

Support passing of interval and condition in podman wait calls

Open rhatdan opened this issue 1 year ago • 4 comments

Signed-off-by: Daniel J Walsh [email protected]

Jul 08 '22 10:07 rhatdan

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

Jul 08 '22 10:07 openshift-ci[bot]

@cdoern Could you take this one over. Would like to get it in, but I have no time to work on it.

Aug 09 '22 18:08 rhatdan

@cdoern Could you take this one over. Would like to get it in, but I have no time to work on it.

sure. might not be before 4.2 gets cut tmrw but I will get it done

Aug 09 '22 18:08 cdoern

That is fine with me.

Aug 09 '22 18:08 rhatdan

@cdoern any progress.

Sep 02 '22 11:09 rhatdan

@cdoern any progress.

This is on my docket for today, I think I'll be able to get it done relatively easily I started looking at it on Tuesday.

Sep 02 '22 12:09 cdoern

@rhatdan do you want me to make a separate PR based off of your changes? I just rebased against your branch.

Sep 02 '22 16:09 cdoern

Yes you can just grab the work I have done and complete it.

Sep 03 '22 11:09 rhatdan