podman-py icon indicating copy to clipboard operation
podman-py copied to clipboard

upstream management of gating tests for distro consumption

Open lsm5 opened this issue 4 years ago • 6 comments

Fedora/RHEL etc. will need gating tests to be run along with the rpm updates. Something along the lines of podman-tests and buildah-tests subpackages that we already have.

podman and buildah tests are in bats, while podman-py tests are in python.

We need to decide on how to manage/maintain tests upstream so distros can easily consume them.

lsm5 avatar Jun 09 '21 18:06 lsm5

I gotta check if gating tests can use something other than bats.

lsm5 avatar Jun 09 '21 18:06 lsm5

I gotta check if gating tests can use something other than bats.

https://docs.fedoraproject.org/ko/ci/gating/ .. doesn't specify any language requirement. I can try just creating a new subpackage and see how things go.

lsm5 avatar Jun 09 '21 18:06 lsm5

@lsm5 If bats is required, I recommend we encapsulate the existing tests in a bats wrapper. This would require the podman-python-tests rpm to require all the necessary python3 and podman-py testing packages.

Note: The integration tests require a working podman instance.

jwhonce avatar Jun 09 '21 18:06 jwhonce

Note: The integration tests require a working podman instance.

@edsantiago will this be the same situation as we discussed earlier today for crun?

lsm5 avatar Jun 09 '21 18:06 lsm5

BATS isn't required, at all. You just need something that conforms to the Fedora gating-test spec: a gating.yaml (easy) and a tests/tests.yml structure (hard).

edsantiago avatar Jun 09 '21 19:06 edsantiago

I'll check out some other python rpm packages to get started with.

lsm5 avatar Jun 10 '21 13:06 lsm5

@lsm5 is this still an issue?

umohnani8 avatar Jan 23 '24 12:01 umohnani8

@lsm5 is this still an issue?

Closing for now. I'll revisit this later. Thanks

lsm5 avatar Jan 23 '24 12:01 lsm5