podman-desktop icon indicating copy to clipboard operation
podman-desktop copied to clipboard

feat: makes containers port(s) list multi line

Open axel7083 opened this issue 1 year ago • 2 comments

What does this PR do?

To be able to have a Forward button on the container's ports, we need to have a little bit more space. This PR change the single line all ports in one, to a multi line per port.

See https://github.com/containers/podman-desktop/issues/9273#issuecomment-2432358681 for the mockup I made (reason why we need more space)

:warning: this code cannot be reused for service as container.ports are Array<V1ContainerPort> and services.port are V1ServicePort and they do not share the same ports.

Screenshot / video of UI

Before

image

After

image

What issues does this PR fix or reference?

Required for https://github.com/containers/podman-desktop/issues/9273

How to test this PR?

  • [x] Tests are covering the bug fix or the new feature

axel7083 avatar Oct 23 '24 13:10 axel7083

suggestion: rather than saying 'we need more space', explain how the feature/button will appear. Then people can say if it'll help or not for the mockup.

benoitf avatar Oct 23 '24 14:10 benoitf

suggestion: rather than saying 'we need more space', explain how the feature/button will appear. Then people can say if it'll help or not for the mockup.

Yes! Sorry I wanted to put a comment on the issue and I forgot: updated now :+1:

axel7083 avatar Oct 23 '24 14:10 axel7083

Yes! Sorry I wanted to put a comment on the issue and I forgot: updated now 👍

suggestion: add the button in the image where it will added so people can quickly see why is it needed, how this pr will solve the problem and then assert that it's the best path

benoitf avatar Oct 24 '24 07:10 benoitf