podman-desktop icon indicating copy to clipboard operation
podman-desktop copied to clipboard

feat: provide ability to easily get a shell in a machine - backend changes - additional changes

Open gastoner opened this issue 1 year ago • 1 comments

What does this PR do?

Provide the ability to ssh to podman machine - backedn changes

-Needs to be rebased

Screenshot / video of UI

https://github.com/user-attachments/assets/32035160-69a4-480f-a9d7-f989e742718d

What issues does this PR fix or reference?

Part of #889

How to test this PR?

Create a podman machine, open terminal

  • [x] Tests are covering the bug fix or the new feature

gastoner avatar Oct 23 '24 12:10 gastoner

I am not sure to understand what is the change goal in this PR :(

The goal is to expose close function to frontend using window.shellInProviderConnectionClose

gastoner avatar Oct 23 '24 12:10 gastoner

@benoitf @axel7083 updated, I just can't make the mocks working as I want (I want to check that the dispose is called for every listener)

gastoner avatar Oct 24 '24 09:10 gastoner

suggestion: move out the test that is not working in another PR (so we don't forget), and remove the non-working test from this one

then we can iterate in parallel

benoitf avatar Oct 24 '24 14:10 benoitf