podman-desktop
podman-desktop copied to clipboard
containers
chore: change hardcoded colors to color registry - part 6
Signed-off-by: Sonia Sandler [email protected]
What does this PR do?
Updates any bg- and text- hardcoded colors to use the color registry
Changes to the color registry:
Each of the providers in PD have a certain colors assigned to them, so I have added them to the registry based on ProviderInfoCircle.svelte:
- Podman - purple
- Docker - sky[400]
- Kubernetes - sky[600]
- unknown - gray
The services also have assigned colors in PD, so they also have been added to the registry based on ServiceColumnType.svelte:
- ClusterIP - sky[500]
- LoadBalancer - purple[500]
- NodePort - fuschia[600]
- unknown - gray
I have also added title-hover-bg so that the circle will be visible when hovering the buttons in the titlebar after changing it to use the color registry
Screenshot / video of UI
What issues does this PR fix or reference?
https://github.com/containers/podman-desktop/issues/9080
How to test this PR?
- [ ] Tests are covering the bug fix or the new feature
@deboer-tim this PR includes new colors in the registry for services, providers, and the titlebar hover bg. Based on https://github.com/containers/podman-desktop/pull/9420#issuecomment-2423121485, do we want to keep the provider colors hardcoded? and as for the service colors, should I just move them to the badge section?
@deboer-tim I've updated the service colors to have more general names and be in the badge section. lmk if I should keep the providers' colors hardcoded or if having them in the colors registry is ok.
I still don't love having three provider colors (podman, docker, Kubernetes) and putting these in the registry; if we did then I think we should at least use the correct colors ourselves vs the palette. This might be a good conversation for the UX call though, maybe I am a minority or someone has a better idea.
IMHO this PR is still too big though, I would recommend to keep splitting out the obvious goodness & cleanup into separate PRs.
