podman-desktop icon indicating copy to clipboard operation
podman-desktop copied to clipboard

updated the Docker compatibility section

Open shipsing opened this issue 1 year ago • 2 comments

What does this PR do?

Look at the migrating from Docker section in entirety to remove the sections that are not needed anymore (because UI implementation provides that capability) and edit the sections for clarity.

Screenshot / video of UI

PR preview: https://671218cecfdb127f43749cb9--podman-desktop-pr.netlify.app/docs/migrating-from-docker

What issues does this PR fix or reference?

https://github.com/containers/podman-desktop/issues/9138

How to test this PR?

  • [ ] Tests are covering the bug fix or the new feature

shipsing avatar Oct 16 '24 11:10 shipsing

Once the Docker Compatibility feature is fully implemented in UI, we would need to remove the following sections that cover the manual approach:

  • https://podman-desktop.io/docs/migrating-from-docker/emulating-docker-cli-with-podman
  • https://podman-desktop.io/docs/migrating-from-docker/verifying-your-tools-are-using-podman
  • https://podman-desktop.io/docs/migrating-from-docker/using-podman-mac-helper 

Edit this section to highlight the content is applicable only to Windows and Linux platforms. Because with the Third-Party Docker Tool compatibility settings avaialable on macOS, you can use the third-party tools without following the manual approach mentioned in that section.

More concised and focused approach to quickly set up Docker compatibility would be to first import your saved containers using CLI and then access the Docker Compatibility page for configuring the settings. 

Also, need to add a screenshot in the Docker Compatibility section.

shipsing avatar Oct 16 '24 11:10 shipsing

Once the Docker Compatibility feature is fully implemented in UI, we would not need to remove the following sections that cover the manual approach:

Edit this section to highlight the content is applicable only to Windows and Linux platforms. Because with the Third-Party Docker Tool compatibility settings avaialable on macOS, you can use the third-party tools without following the manual approach mentioned in that section.

More concised and focused approach to quickly set up Docker compatibility would be to first import your saved containers using CLI and then access the Docker Compatibility page for configuring the settings. 

Also, need to add a screenshot in the Docker Compatibility section.

Should this PR be in draft then until the PR for compatibility section is in?

Otherwise, the docs LGTM (as it's just removing or moving paragraphs around anyways).

cdrage avatar Oct 21 '24 15:10 cdrage

@benoitf, I have incorporated your suggestions. Could you please verify the PR? Also, can we merge the PR now or do we have to wait till 4.15 is out?

shipsing avatar Nov 15 '24 06:11 shipsing

Also, can we merge the PR now or do we have to wait till 4.15 is out?

I think it's ok having that merged now and not waiting until 4.15

benoitf avatar Nov 15 '24 07:11 benoitf