podman-desktop icon indicating copy to clipboard operation
podman-desktop copied to clipboard

chore: process podman system and user configuration

Open vzhukovs opened this issue 1 year ago • 7 comments

What does this PR do?

The purpose of this changes request is to provide the complex mechanism to process Podman system and user based configuration. According to the latest changes in Podman new.go there is a need to implement the same logic in Podman Desktop to process these configuration files.

Screenshot / video of UI

No screenshots. Changes are invisible from the user perspective.

What issues does this PR fix or reference?

#7027

How to test this PR?

Podman Desktop should take into account Podman system-based and user-based configuration. So, no visual check on the UI. The only thing is to check, that the current PR works the same as https://github.com/containers/podman-desktop/pull/7881 and https://github.com/containers/podman-desktop/pull/7540 intended.

  • [x] Tests are covering the bug fix or the new feature

vzhukovs avatar Jul 02 '24 12:07 vzhukovs

@jeffmaury the PR is ready to be reviewed again

vzhukovs avatar Nov 12 '24 12:11 vzhukovs

I have added qe/testing-required label since I think we need to make sure not to introduce regression. I have run windows e2e tests with the branch:

  • hyperv provider: https://github.com/podman-desktop/e2e/actions/runs/12749549135 (1 failure on win 10 - investigating...)
  • wsl: https://github.com/podman-desktop/e2e/actions/runs/12749557340

Would be great to have also Mac OS tested since I think mac is also impacted, @cbr7 PTAL, please?

odockal avatar Jan 13 '25 16:01 odockal

I've ran all the e2e tests on mac for both applehv and libkrun podman machines and the tests ran fine, seems good to me.

cbr7 avatar Jan 14 '25 08:01 cbr7

@jeffmaury can we proceed with merge?

vzhukovs avatar Feb 17 '25 16:02 vzhukovs

PTAL @jeffmaury

benoitf avatar Mar 14 '25 09:03 benoitf

@vzhukovs can you please have a look at the conflicts so it can be merged?

jiridostal avatar Jun 18 '25 12:06 jiridostal

@jiridostal this PR needs to be rewritten from scratch, because there were a few breaking changes in this functionality, so will take a look on it asap, maybe there will be a separate PR and this will be closed.

vzhukovs avatar Jun 18 '25 13:06 vzhukovs

I'm going to mark this as draft so people do not get pinged to review the PR until conflicts have been updated.

cdrage avatar Jul 10 '25 20:07 cdrage

closing as not updated

benoitf avatar Nov 05 '25 10:11 benoitf