podman-desktop
podman-desktop copied to clipboard
Dashboard podman row is misaligned to the right
Bug description
It seems that the Podman section on the dashboard is misaligned to the right, making all the buttons not be centered.
Operating system
macOS, win
Installation Method
Installer from website/GitHub releases
Version
1.10.0
Steps to reproduce
- Install PD 1.10
- Go to the Dashboard.
- Notice section is not aligned to the center.
Relevant log output
No response
Additional context
No response
It is dupe of https://github.com/containers/podman-desktop/issues/6959. But it got better pictures, so I will close the former issue.
@odockal @cbr7 i just tried using the main branch and it works fine to me on the onboarding. Could you give this a try?
I'm looking for the design on penpot to see how the button should be positioned (for the dashboard)
@lstocchi reproduced on main branch:
The issue isn't in the onboarding, it's in the Dashboard.
@lstocchi reproduced on main branch:
The issue isn't in the onboarding, it's in the Dashboard.
Aaaah ok, I was able to reproduce. By looking at the image made by Ondrej it looked to me the onboarding step 🤦 . Thanks!
Need to reopen this issue, the previous fix was incomplete, on the dashboard the Podman section is still misaligned to the right in PD version 1.10.1:
I'm not sure to get what's the problem. Do you think that the "initialize and start" button or the "View detection" and "install" should not be on the right?
@lstocchi yes, those buttons should be centered as they were previously.
I think this change is the wanted behavior. It was made by @ekidneyrh here https://github.com/containers/podman-desktop/pull/6768 if i get it right. Could you confirm how this should work @ekidneyrh ? Thanks!!
@lstocchi but even in the picture from that PR you can see the "View detection checks" button centered with the text somewhat, not isolated to the right edge.
Yah, ideally it would be centred within its 'cell'. And then the cells stretch with the window, if that makes sense? So three cells across
Isn't it that the problem lays in the middle cell where is a text regarding podman/podman machine or a progress or machine creation (on windows when you initialize the machine from there) ? That alignment of the middle cell seems to be not in the center but on the left. Then there is too much space between the text and buttons on the right?
Yah, ideally it would be centred within its 'cell'. And then the cells stretch with the window, if that makes sense? So three cells across
Sorry @ekidneyrh , was busy on other things.
It is not clear to me which cell should be stretched, just the central one?
Let's say i have icon | small description | button
On a wide screen it should look like
icon | small description | button
or
icon | small description | button
I suppose I thought it could be that they all stretch, but the ratio is 1:2:1 kinda thing? So the middle column is by default larger than the other two. And then when they stretch, column 1 is aligned left, and the other two aligned to their own respective centres.
I suppose I thought it could be that they all stretch, but the ratio is 1:2:1 kinda thing? So the middle column is by default larger than the other two. And then when they stretch, column 1 is aligned left, and the other two aligned to their own respective centres.
Ok, i'll work on the 1:2:1 ratio to see how it looks like and we can discuss on that 👍