podman-desktop icon indicating copy to clipboard operation
podman-desktop copied to clipboard

Published 20 hours ago • verified publisher icon containers

chore(UI): migrate spinner to UI package

Open axel7083 opened this issue 9 months ago • 4 comments

What does this PR do?

Move the Spinner.svelte component from the renderer to the ui package.

Plus adding the $$props.class and $$props.style for better usage

Screenshot / video of UI

What issues does this PR fix or reference?

Fixes https://github.com/containers/podman-desktop/issues/6897

How to test this PR?

  • [x] Tests are covering the bug fix or the new feature

axel7083 avatar Apr 25 '24 13:04 axel7083

will be post 1.10

benoitf avatar Apr 25 '24 15:04 benoitf

Tag v1.10.0 🥳 has been released !

axel7083 avatar Apr 29 '24 07:04 axel7083

should we have a minimal unit test for Spinner ?

Everything is possible 🙈 @benoitf

axel7083 avatar Apr 29 '24 07:04 axel7083

Tag v1.10.0 🥳 has been released !

sorry, I think I wasn't clear enough when speaking about 1.10 being released. It was not for 1.10.0 but the one that will be promoted (so if we need any backport it's very easy)

benoitf avatar Apr 30 '24 09:04 benoitf