podman-desktop icon indicating copy to clipboard operation
podman-desktop copied to clipboard

Published 20 hours ago • verified publisher icon containers

Implement StarIcon UI component

Open jeffmaury opened this issue 1 year ago • 1 comments
trafficstars

jeffmaury avatar Apr 24 '24 12:04 jeffmaury

IMHO this should just be used internally by StatusIcon, I don't think we're using it directly anywhere.

deboer-tim avatar Apr 24 '24 12:04 deboer-tim

is there an issue to move StatusIcon ?

benoitf avatar May 21 '24 15:05 benoitf

cc @jeffmaury

axel7083 avatar May 21 '24 15:05 axel7083

if we don't move StatusIcon then we can close the issue, if we move it, we move this file but do not expose it

benoitf avatar May 21 '24 16:05 benoitf

StarIcon is used by bootc extension: https://github.com/containers/podman-desktop-extension-bootc/blob/main/packages/frontend/src/lib/BootcStatusIcon.svelte

jeffmaury avatar May 21 '24 16:05 jeffmaury

I guess I was't clear above, but bootc is only using StarIcon because it implements its own StatusIcon. I think it would be cleaner if a reusable form of StatusIcon was exposed (which wouldn't need to expose StarIcon).

deboer-tim avatar May 21 '24 19:05 deboer-tim