podman-desktop icon indicating copy to clipboard operation
podman-desktop copied to clipboard

fix: stop provider card overflow

Open deboer-tim opened this issue 1 year ago • 1 comments

What does this PR do?

Small tweaks to ProviderCard to make sure the icon margin isn't growing and right column is growing correctly. Uses max-w-xs to limit the width of the right column wherever text was not wrapping correctly. Removes redundant provider version from the configured state.

Even with these changes it is still possible to get overlap when the window is between 640px (the minimum) and 690px wide. We're at the point where the required content does not fit the current design. If anyone else has a suggestion I'm willing to try it, but IMHO it may not be worth it as this is more of an extreme/edge case now, and we've been waiting for a couple sprints now on a design for moving some of the actions to other places like Resources.

Since this is visual overlap of elements not staying within their flex layout I can't think of any useful tests.

Screenshot / video of UI

Before Screenshot 2023-12-19 at 10 42 23 PM

After: Screenshot 2023-12-19 at 10 42 04 PM

What issues does this PR fix or reference?

Fixes #5316 (mostly).

How to test this PR?

Just make the window narrow.

deboer-tim avatar Dec 20 '23 03:12 deboer-tim

move to draft as no update

benoitf avatar Mar 12 '24 17:03 benoitf