chore: add isMac to package.json for editing a machine

[SoniaSandler]

Signed-off-by: Sonia Sandler [email protected]

What does this PR do?

Right now, editing a podman machine is only possible on macOS. However, as part of https://github.com/podman-desktop/podman-desktop/pull/12781, the rootful status is also editable on both macOS and Windows, so we need to indicate which properties are editable only on macOS.

Screenshot / video of UI

What issues does this PR fix or reference?

Related to https://github.com/podman-desktop/podman-desktop/pull/12781

How to test this PR?

• [ ] Tests are covering the bug fix or the new feature

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:loudspeaker: Thoughts on this report? Let us know!

[jeffmaury]

Curious to know if this is really only working on Mac, or would work for windows HyperV (I know it is not working for WSL, but not sure abotu hyperV)

cc @jeffmaury

CPU and memory should be exposed for HyperV

[SoniaSandler]

@axel7083 @jeffmaury right now the podman machine editing option is only registered for macOS

[jeffmaury]

@axel7083 @jeffmaury right now the podman machine editing option is only registered for macOS

So we should create a follow up issue as I would guess HyperV support was added after edit and that was missed

[coderabbitai[bot]]

📝 Walkthrough

"""

Walkthrough

The changes update the Podman extension to conditionally support editing machine resource settings—CPUs, memory, and disk size—based on the operating system and virtualization capabilities. New exported context keys (PODMAN_MACHINE_EDIT_CPU, PODMAN_MACHINE_EDIT_MEMORY, PODMAN_MACHINE_EDIT_DISK_SIZE) are introduced and set according to platform detection, including Hyper-V status on Windows. The provider registration logic and extension configuration use these flags to control the visibility and availability of editing features. The lifecycle's edit method is extended to support macOS and Windows Hyper-V for CPU and memory editing, while disk size editing remains macOS-only. Corresponding tests are enhanced to verify correct context key settings and edit capability detection across macOS, Windows (with and without Hyper-V), and Linux. No other public API changes were made.

Estimated code review effort

2 (~20 minutes)

Suggested labels

qe/testing-required

Suggested reviewers

• jeffmaury
• axel7083
• benoitf """

[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

extensions/podman/packages/extension/src/extension.ts

Oops! Something went wrong! :(

ESLint: 9.30.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'svelte-eslint-parser' imported from /eslint.config.mjs at Object.getPackageJSONURL (node:internal/modules/package_json_reader:255:9) at packageResolve (node:internal/modules/esm/resolve:767:81) at moduleResolve (node:internal/modules/esm/resolve:853:18) at defaultResolve (node:internal/modules/esm/resolve:983:11) at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:801:12) at #cachedDefaultResolve (node:internal/modules/esm/loader:725:25) at ModuleLoader.resolve (node:internal/modules/esm/loader:708:38) at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:309:38) at #link (node:internal/modules/esm/module_job:202:49)

---

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ccc48cf104d1ac56079f711dad43f9b1cfe29306 and 67abd5aa5b8f5fc329aa403c2ceb492204d0ba8c.

📒 Files selected for processing (1)

• extensions/podman/packages/extension/src/extension.ts (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• extensions/podman/packages/extension/src/extension.ts

✨ Finishing Touches

• [ ] 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[SoniaSandler]

@axel7083 @cdrage @feloy Could you PTAL at this PR? thanks!