podman-desktop-extension-ai-lab icon indicating copy to clipboard operation
podman-desktop-extension-ai-lab copied to clipboard

When a recipe repository is updated, the local repository is never updated

Open feloy opened this issue 10 months ago • 0 comments

If commits are added to the branch of a recipe's repository, the user's local clone is not updated with the latest version, including the added commits.

It is not reproducible with current catalog as we are using fixed commit ids in the catalog for now, but it can be reproduced if a user adds recipes to its user's catalog using a branch/tag name for the repository's ref.

There is an inconsistency in the code of processCheckout (gitManager.ts). The call to isRepositoryUpToDate can return { ok: true, updatable: true } if the remote branch is ahead of the local branch, but we return directly if ok is true:

      if (result.ok) {
        return;
      }

and the value of result.updatable is being read after this early return.

feloy avatar Apr 04 '24 09:04 feloy