podman-compose icon indicating copy to clipboard operation
podman-compose copied to clipboard
verified publisher icon containers

Add --health-on-failure, fixes containers/podman-compose#747

Open hunter86bg opened this issue 1 year ago • 2 comments

Contributor Checklist:

This PR adds the option to stop/restart container when healtcheck fails.

hunter86bg avatar May 31 '24 09:05 hunter86bg

@p12tic , what do you think about this one ?

hunter86bg avatar May 31 '24 09:05 hunter86bg

@hunter86bg As I understand, this is not part of docker-compose specification. Accordingly, on_failure key should be x-podman.on_failure and also it should be documented in https://github.com/containers/podman-compose/blob/main/docs/Extensions.md. Also please add unit tests. There are a lot of examples how to write tests for container_to_args in repository history. For example, see pytests/ part of https://github.com/containers/podman-compose/pull/925.

p12tic avatar Jun 02 '24 20:06 p12tic