nri-plugins icon indicating copy to clipboard operation
nri-plugins copied to clipboard

create tag pkg/topology/v0.1.0

Open mythi opened this issue 2 years ago • 7 comments

It's not possible to use v0.1.0 tag for pkg/topology:

If a module is defined in a subdirectory within the repository, that is, the module subdirectory portion of the module path is not empty, then each tag name must be prefixed with the module subdirectory, followed by a slash. For example, the module golang.org/x/tools/gopls is defined in the gopls subdirectory of the repository with root path golang.org/x/tools. The version v0.4.0 of that module must have the tag named gopls/v0.4.0 in that repository.

https://go.dev/ref/mod#vcs-version

mythi avatar Jul 17 '23 05:07 mythi

What would you want this for? Do we really want to start serving different packages as separately served go modules? I wouldn't

marquiz avatar Jul 25 '23 08:07 marquiz

We have had pkg/topology maintained in two places and now this repo could serve the proper upstream for downstream users too https://github.com/intel/intel-device-plugins-for-kubernetes/pull/1379

mythi avatar Jul 25 '23 09:07 mythi

Do we really want to start serving different packages as separately served go modules?

it's also not a new ask but pkg/topology has been served long time already.

mythi avatar Jul 25 '23 09:07 mythi

WDYT? This mostly complements the existing v0.1.0 tag.

mythi avatar Aug 01 '23 14:08 mythi

WDYT? This mostly complements the existing v0.1.0 tag.

ping

mythi avatar Sep 05 '23 10:09 mythi

@mythi Is this still relevant ?

klihub avatar Dec 21 '24 10:12 klihub

I'm still not able to use a shared pkg/topology from anywhere but OTOH, it's not a priority right now either.

mythi avatar Jan 02 '25 11:01 mythi