nri-plugins icon indicating copy to clipboard operation
nri-plugins copied to clipboard
verified publisher icon containers

make golangci-lint fails

Open mythi opened this issue 2 years ago • 3 comments

...with a bunch of linter errors (golangci-lint has version v1.50.1)

mythi avatar Apr 14 '23 05:04 mythi

Perhaps it would be also good to add a github action to run golangci-lint as part of presubmit?

fmuyassarov avatar Apr 17 '23 07:04 fmuyassarov

Perhaps it would be also good to add a github action to run golangci-lint as part of presubmit?

Yes, once we have fixed this. It is a known issue and the reason why we haven't enabled running golangci-lint as part of our github actions yet.

klihub avatar Apr 17 '23 08:04 klihub

I have submitted a fix for all the issues currently reported by the linter. Maybe we can enable it once https://github.com/containers/nri-plugins/pull/25 gets merged.

fmuyassarov avatar Apr 17 '23 08:04 fmuyassarov

All known issues should be fixed in latest main/HEAD and in v0.8.0, golangci-lint enabled in CI.

klihub avatar Dec 21 '24 10:12 klihub