image icon indicating copy to clipboard operation
image copied to clipboard

The docker CLI bump PR #2727 was never actually released

Open Skarlso opened this issue 10 months ago • 7 comments

Hello.

There was a PR to bump the docker version about a month ago: #2727.

This PR was never released. The latest tag contains the old version.

	github.com/docker/cli v27.5.1+incompatible
	github.com/docker/distribution v2.8.3+incompatible
	github.com/docker/docker v27.5.1+incompatible

Skarlso avatar Mar 18 '25 11:03 Skarlso

Thanks for your report.

The docker/cli package is only used in tests, and its use in c/image should not be relevant to users (other than the indirect effects via Go’s module dependency semantics).

Now, docker/docker is actually used — and it broke API, which is awkward.

I don’t think it makes much sense to update on the 5.34.x release branch, forcing users of c/image to update a large dependency (tree) on a supposedly-stable branch.

And on the main branch, there are not that many features to merit tagging a release… that’s admittedly not at all a strong reason not to tag a new release.

mtrmac avatar Mar 18 '25 19:03 mtrmac

I'm okay with whatever, however, right now, we can't update to docker v0.28 ourself because we use containers/image as a dependency and then things start to break.

Skarlso avatar Mar 19 '25 08:03 Skarlso

@TomSweeneyRedHat in case I’m missing something: would anything break if c/image upstream tagged a 5.35 now, independently from the Podman schedule?

mtrmac avatar Mar 19 '25 16:03 mtrmac

I'm okay with whatever, however, right now, we can't update to docker v0.28 ourself because we use containers/image as a dependency and then things start to break.

Any reason why you couldn't bump to c/image@main?

would anything break if c/image upstream tagged a 5.35 now, independently from the Podman schedule?

I think we greatly benefit from aligned releases schedules in general so I think some only c/image release might be confusing, especially if you consider that c/storage@main is set here right now so if we end up doing another c/storage v1.57.4 then all users would get offered a "downgrade" and the build breaks. So I would think it would also need a matching c/storage release.

Luap99 avatar Mar 26 '25 13:03 Luap99

If I try to update your thing and docker ->

# github.com/containers/image/v5/docker/daemon
../../../go/pkg/mod/github.com/containers/image/[email protected]/docker/daemon/daemon_dest.go:95:40: cannot use true (constant of type bool) as client.ImageLoadOption value in argument to c.ImageLoad: bool does not implement client.ImageLoadOption (missing method Apply)

Skarlso avatar Mar 26 '25 13:03 Skarlso

go get github.com/containers/image/v5@main ?

mtrmac avatar Mar 26 '25 16:03 mtrmac

Sure, main works. But that's not desirable. :)

Skarlso avatar Mar 26 '25 16:03 Skarlso

There is a v5.35.0 tag now

Luap99 avatar May 02 '25 10:05 Luap99