image
image copied to clipboard
containers
Export BuiltinDefaultPolicyPath
This field is duplicated in containers/common/pkg/config and is being vendored into bindings, just because it is not exported from containers/image.
I don’t immediately know; the way the code has already diverged, maybe there is some neat elegant solution which is compatible enough, maybe we will have to live with a gross hack forever. Someone needs to figure that out.
For the purpose of trimming https://github.com/containers/podman/pull/23857#issuecomment-2328356840 , the bindings should not be including the whole implementation in pkg/trust in the first place; AFAICS they just need the trust.Policy data type. That can either be split into a subpackage; or the domain/entities/types subpackage could define a separate RPC-only type, separate from the implementation type; or maybe pkg/trust should be importing the type from domain/entities/types — I don’t know what is the general Podman approach to RPC-only types duplicated with implementation types, vs. sharing the two, and where the definitions live.
Hi, and thank you for your contribution!
We’ve recently migrated this repository into a new monorepo: containers/container-libs along with other repositories
As part of this migration, this repository is no longer accepting new Pull-Requests and therefore this Pull-Request is being closed.
Thank you very much for your contribution. We would appreciate your continued help in migrating this PR to the new container-libs repository. Please let us know if you are facing any issues.
You can read more about the migration and the reasoning behind it in our blog post: Upcoming migration of three containers repositories to monorepo.
Thanks again for your work and for supporting the containers ecosystem!
