image icon indicating copy to clipboard operation
image copied to clipboard

Update stubs to match signature of actual methods

Open SpangleLabs opened this issue 1 year ago • 1 comments

#2526 has broken building v5.32.2 with the containers_image_fulcio_stub and containers_image_rekor_stub build tags, as the signatures for verifyRekorFulcio() and VerifyRekorSET() were updated without updating the corresponding stubs.

This PR updates the stubs to match

SpangleLabs avatar Aug 27 '24 14:08 SpangleLabs

Thanks!

First, https://github.com/containers/image/blob/main/CONTRIBUTING.md#sign-your-prs please, we can’t really even look at contributions with unclear copyright status.

mtrmac avatar Aug 27 '24 14:08 mtrmac

So sorry I missed this and then got pulled away to other things and forgot to update it! I have updated the commit message now, (and rebased) sorry, and thank you! ^_^

SpangleLabs avatar Nov 06 '24 23:11 SpangleLabs

I’m afraid we broke that build another way since…

https://github.com/containers/image/pull/2632

mtrmac avatar Nov 12 '24 16:11 mtrmac