dnsname
dnsname copied to clipboard
containers
Fix build and install instructions
Instructions did not supply the command to build the binary (make) and therefore the make install would fail because the bin directory did not exist.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ivandov
To complete the pull request process, please assign rhatdan after the PR has been reviewed.
You can assign the PR to them by writing /assign @rhatdan in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
You need to sign your commit message.
git commit -a --amend -s git push --force
Signed the commit, and also realized this is almost identical to PR #93 which address issue #91.
Not sure if this PR should be closed since #93 looks to be further into the review process?
CI is failing, seems unrelated. @Luap99 Is this the same thing that hit Podman CI?
It related but no the same problem. The go version is just to old to compile ginkgo.
Looks like the VM images are very old cc @cevich
Looks like the VM images are very old
Yes, we just got buildah and skopeo updated last week. I need to make a jira card for updating all the others (there's a lot of them).
This repo (and dnsname) are deprecated. We've switched all development efforts over to the Netavark network stack.
@Luap99 @baude Should we consider archiving this repo?
I think CI can be disabled. Not so sure about archiving, dnsname is still shipped in distros and we might need to provide CVE fixes in the future?