dnsname icon indicating copy to clipboard operation
dnsname copied to clipboard

fix: issue #91, missing steps on readme

Open HectorMRC opened this issue 2 years ago • 6 comments

Step missing on 'build and install' step from mini-tutorial + no 2nd step on 'enabling name resolution on the default Podman network'.

HectorMRC avatar Apr 02 '22 19:04 HectorMRC

/assign @mheon

HectorMRC avatar Apr 02 '22 19:04 HectorMRC

LGTM

mheon avatar Apr 04 '22 14:04 mheon

Per CI, your commit has whitespace errors that can be viewed by git show --check bce593bba452dde45c272e3af22b294ad7f14d7b, and requires a signoff (git commit --amend -s should add one).

mheon avatar Apr 04 '22 14:04 mheon

/approve

mheon avatar Apr 04 '22 14:04 mheon

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HectorMRC, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Apr 04 '22 14:04 openshift-ci[bot]

@mheon all validation errors have been resolved, Tide's check is pending for lgtm label

HectorMRC avatar May 29 '22 17:05 HectorMRC