crun
crun copied to clipboard
Add support for ppc64le
This PR adds ppc64le CPU architecture as a build target. There is no change content-wise.
Signed-off-by: Marvin Giessing [email protected]
@giuseppe PTAL LGTM
LGTM once tests are green
I checked the test logs and this seems to be an issue currently:
2022-08-25T18:00:35.2070476Z builder for '/nix/store/bwhcv14nl1inia99q8k433qgbpp4x6by-curl-powerpc64le-unknown-linux-gnu-7.84.0.drv' failed with exit code 2; last 10 log lines:
2022-08-25T18:00:35.2071202Z easy_lock.h: In function 'curl_simple_lock_lock':
2022-08-25T18:00:35.2072167Z easy_lock.h:56:7: error: implicit declaration of function 'sched_yield' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-function-declaration-Werror=implicit-function-declaration8;;]
2022-08-25T18:00:35.2072756Z 56 | sched_yield();
2022-08-25T18:00:35.2073000Z | ^~~~~~~~~~~
2022-08-25T18:00:35.2073290Z cc1: some warnings being treated as errors
2022-08-25T18:00:35.2073712Z make[2]: *** [Makefile:2234: libcurl_la-easy.lo] Error 1
2022-08-25T18:00:35.2074435Z make[2]: Leaving directory '/tmp/nix-build-curl-powerpc64le-unknown-linux-gnu-7.84.0.drv-0/curl-7.84.0/lib'
2022-08-25T18:00:35.2074967Z make[1]: *** [Makefile:1365: all] Error 2
2022-08-25T18:00:35.2075589Z make[1]: Leaving directory '/tmp/nix-build-curl-powerpc64le-unknown-linux-gnu-7.84.0.drv-0/curl-7.84.0/lib'
2022-08-25T18:00:35.2076217Z make: *** [Makefile:1240: all-recursive] Error 1
That issue is referenced here https://github.com/curl/curl/issues/9136 and seems to be fixed in curl 7.85.
I'm not very experienced with the nix build system...can we somehow bump curl 7.84 to 7.85 or you got another idea...?
Thanks!
that looks like a good idea. Could you run make nixpkgs and see if it updates any dependency?
Mhh, that doesn't seem to update nix:
mgiessing@edc36bef23e0:~/crun$ nix-env -qa curl
curl-7.84.0
curl-7.84.0
curl-7.84.0
curl-7.84.0
curl-7.84.0
Mhh, that doesn't seem to update nix:
mgiessing@edc36bef23e0:~/crun$ nix-env -qa curl curl-7.84.0 curl-7.84.0 curl-7.84.0 curl-7.84.0 curl-7.84.0
that seems to be the version currently available: https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/networking/curl/default.nix#L51
as well as the last released version: https://curl.se/download.html
curl 7.85.0
- is released: https://github.com/curl/curl/releases/tag/curl-7_85_0
- went into staging branch of NixOS: https://github.com/NixOS/nixpkgs/pull/189083
but it's not yet available in master (AFAICS)
@mgiessing could you give it another try?
I'm currently having a few issues with my new build host (my reservations only last for 5-7 days), but as curl is not yet in master branch I'd give it a try once it got there ok?
@mgiessing are you still working on this?
7.85 isn't in master yet but it should be soon, this staging cycle was a bit slower than usual.
https://nixpk.gs/pr-tracker.html?pr=189083 is probably the easiest way to track progress.
@giuseppe do you have a way to retry this?
rebased + retry as curl 7.85 is in master
I'm a bit confused, why is it still using curl 7.84 when 7.85 should be the default? Can anyone who has experience with nix explain this issue and ideally knows what to do...? Thanks!
@mgiessing could you give this another try?
rebased the PR @giuseppe I think it needs again some approval
same error :/
did you run make nixpkgs?
I've amended the change to this PR
it seems to be a different error now
moved my changes here: https://github.com/containers/crun/pull/1122
closing in favor of #1123