crun icon indicating copy to clipboard operation
crun copied to clipboard

Add support for ppc64le

Open mgiessing opened this issue 3 years ago • 9 comments

This PR adds ppc64le CPU architecture as a build target. There is no change content-wise.

Signed-off-by: Marvin Giessing [email protected]

mgiessing avatar Aug 25 '22 15:08 mgiessing

@giuseppe PTAL LGTM

rhatdan avatar Aug 25 '22 15:08 rhatdan

LGTM once tests are green

giuseppe avatar Aug 25 '22 21:08 giuseppe

I checked the test logs and this seems to be an issue currently:

2022-08-25T18:00:35.2070476Z builder for '/nix/store/bwhcv14nl1inia99q8k433qgbpp4x6by-curl-powerpc64le-unknown-linux-gnu-7.84.0.drv' failed with exit code 2; last 10 log lines:
2022-08-25T18:00:35.2071202Z   easy_lock.h: In function 'curl_simple_lock_lock':
2022-08-25T18:00:35.2072167Z   easy_lock.h:56:7: error: implicit declaration of function 'sched_yield' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-function-declaration-Werror=implicit-function-declaration8;;]
2022-08-25T18:00:35.2072756Z      56 |       sched_yield();
2022-08-25T18:00:35.2073000Z         |       ^~~~~~~~~~~
2022-08-25T18:00:35.2073290Z   cc1: some warnings being treated as errors
2022-08-25T18:00:35.2073712Z   make[2]: *** [Makefile:2234: libcurl_la-easy.lo] Error 1
2022-08-25T18:00:35.2074435Z   make[2]: Leaving directory '/tmp/nix-build-curl-powerpc64le-unknown-linux-gnu-7.84.0.drv-0/curl-7.84.0/lib'
2022-08-25T18:00:35.2074967Z   make[1]: *** [Makefile:1365: all] Error 2
2022-08-25T18:00:35.2075589Z   make[1]: Leaving directory '/tmp/nix-build-curl-powerpc64le-unknown-linux-gnu-7.84.0.drv-0/curl-7.84.0/lib'
2022-08-25T18:00:35.2076217Z   make: *** [Makefile:1240: all-recursive] Error 1

That issue is referenced here https://github.com/curl/curl/issues/9136 and seems to be fixed in curl 7.85.

I'm not very experienced with the nix build system...can we somehow bump curl 7.84 to 7.85 or you got another idea...?

Thanks!

mgiessing avatar Aug 25 '22 21:08 mgiessing

that looks like a good idea. Could you run make nixpkgs and see if it updates any dependency?

giuseppe avatar Aug 26 '22 07:08 giuseppe

Mhh, that doesn't seem to update nix:

mgiessing@edc36bef23e0:~/crun$ nix-env -qa curl
curl-7.84.0
curl-7.84.0
curl-7.84.0
curl-7.84.0
curl-7.84.0

mgiessing avatar Aug 26 '22 10:08 mgiessing

Mhh, that doesn't seem to update nix:

mgiessing@edc36bef23e0:~/crun$ nix-env -qa curl
curl-7.84.0
curl-7.84.0
curl-7.84.0
curl-7.84.0
curl-7.84.0

that seems to be the version currently available: https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/networking/curl/default.nix#L51

as well as the last released version: https://curl.se/download.html

giuseppe avatar Aug 26 '22 20:08 giuseppe

curl 7.85.0

  • is released: https://github.com/curl/curl/releases/tag/curl-7_85_0
  • went into staging branch of NixOS: https://github.com/NixOS/nixpkgs/pull/189083

but it's not yet available in master (AFAICS)

kolyshkin avatar Sep 03 '22 17:09 kolyshkin

@mgiessing could you give it another try?

giuseppe avatar Sep 05 '22 15:09 giuseppe

I'm currently having a few issues with my new build host (my reservations only last for 5-7 days), but as curl is not yet in master branch I'd give it a try once it got there ok?

mgiessing avatar Sep 05 '22 20:09 mgiessing

@mgiessing are you still working on this?

rhatdan avatar Sep 28 '22 23:09 rhatdan

7.85 isn't in master yet but it should be soon, this staging cycle was a bit slower than usual.

https://nixpk.gs/pr-tracker.html?pr=189083 is probably the easiest way to track progress.

zowoq avatar Sep 29 '22 00:09 zowoq

@giuseppe do you have a way to retry this?

rhatdan avatar Oct 13 '22 10:10 rhatdan

rebased + retry as curl 7.85 is in master

mgiessing avatar Oct 21 '22 10:10 mgiessing

I'm a bit confused, why is it still using curl 7.84 when 7.85 should be the default? Can anyone who has experience with nix explain this issue and ideally knows what to do...? Thanks!

mgiessing avatar Oct 21 '22 10:10 mgiessing

@mgiessing could you give this another try?

giuseppe avatar Jan 12 '23 20:01 giuseppe

rebased the PR @giuseppe I think it needs again some approval

mgiessing avatar Jan 12 '23 20:01 mgiessing

same error :/

giuseppe avatar Jan 13 '23 14:01 giuseppe

did you run make nixpkgs?

giuseppe avatar Jan 13 '23 14:01 giuseppe

I've amended the change to this PR

giuseppe avatar Jan 13 '23 14:01 giuseppe

it seems to be a different error now

giuseppe avatar Jan 13 '23 16:01 giuseppe

moved my changes here: https://github.com/containers/crun/pull/1122

giuseppe avatar Jan 13 '23 22:01 giuseppe

closing in favor of #1123

giuseppe avatar Jan 16 '23 08:01 giuseppe