tests: run all py tests with cgroupfs and systemd
Many python tests do not run with systemd, and it makes sense to do so.
Summary by Sourcery
Iterate over both cgroupfs and systemd managers when running all Python tests and propagate CGROUP_MANAGER into test utilities to support both cgroup backends.
New Features:
- Detect and include systemd cgroup manager in test runs when available
- Run each test under both cgroupfs and systemd, generating separate logs and TRS files
Enhancements:
- Default cgroup_manager in run_and_get_output to the CGROUP_MANAGER environment variable when not explicitly provided
Reviewer's Guide
Tests now run under both cgroupfs and systemd when available, with the cgroup manager propagated from environment into the test utility for consistent behavior.
File-Level Changes
| Change | Details | Files |
|---|---|---|
| Run Python tests under both cgroupfs and systemd in CI script |
|
tests/run_all_tests.sh |
| Allow tests_utils to pick cgroup manager from environment when not explicitly passed |
|
tests/tests_utils.py |
Tips and commands
Interacting with Sourcery
- Trigger a new review: Comment
@sourcery-ai reviewon the pull request. - Continue discussions: Reply directly to Sourcery's review comments.
- Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with
@sourcery-ai issueto create an issue from it. - Generate a pull request title: Write
@sourcery-aianywhere in the pull request title to generate a title at any time. You can also comment@sourcery-ai titleon the pull request to (re-)generate the title at any time. - Generate a pull request summary: Write
@sourcery-ai summaryanywhere in the pull request body to generate a PR summary at any time exactly where you want it. You can also comment@sourcery-ai summaryon the pull request to (re-)generate the summary at any time. - Generate reviewer's guide: Comment
@sourcery-ai guideon the pull request to (re-)generate the reviewer's guide at any time. - Resolve all Sourcery comments: Comment
@sourcery-ai resolveon the pull request to resolve all Sourcery comments. Useful if you've already addressed all the comments and don't want to see them anymore. - Dismiss all Sourcery reviews: Comment
@sourcery-ai dismisson the pull request to dismiss all existing Sourcery reviews. Especially useful if you want to start fresh with a new review - don't forget to comment@sourcery-ai reviewto trigger a new review!
Customizing Your Experience
Access your dashboard to:
- Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others.
- Change the review language.
- Add, remove or edit custom review instructions.
- Adjust other review settings.
Getting Help
- Contact our support team for questions or feedback.
- Visit our documentation for detailed guides and information.
- Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.
I'll merge once you are fine with it (no Draft)
This is a draft because I'm not quite sure how the tests are actually run and whether this script is used (if not, we need to supply different value of CGROUP_MANAGER env var, this can probably be done via Makefile).