containrs icon indicating copy to clipboard operation
containrs copied to clipboard

Image pull implementation

Open CertainLach opened this issue 5 years ago • 6 comments

I like the idea of Rust CRI implementation, and want to help in it :D

Is there any implementation plan/architecture description?

If no - i suggest using sled for internal storage, this is fast embedded kv database, which is pretty stable

What type of PR is this?

/kind api-change /kind bug /kind cleanup /kind dependency-change /kind deprecation /kind design /kind documentation /kind failing-test /kind feature /kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #16

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

CertainLach avatar Sep 08 '20 18:09 CertainLach

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: CertainLach To complete the pull request process, please assign harche You can assign the PR to them by writing /assign @harche in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot avatar Sep 08 '20 18:09 openshift-ci-robot

I like the idea of Rust CRI implementation, and want to help in it :D

Nice, that's wonderful to hear! :heart:

Is there any implementation plan/architecture description?

Not yet, but are you interested in contributing to some? :) We could start with a fresh documentation page inside the repository. WDYT?

saschagrunert avatar Sep 08 '20 18:09 saschagrunert

I reduced scope of this PR, because currently i stuck at some bits of multiple transports support, feel free to merge this as partially finished work, i will commit more transports soon :D

CertainLach avatar Sep 10 '20 21:09 CertainLach

Can you please rebase and resolve the conflict? :innocent: Fixing the CI would be necessary now too.

saschagrunert avatar Sep 11 '20 08:09 saschagrunert

@CertainLach: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Sep 12 '20 14:09 openshift-ci-robot

@CertainLach do you mind giving this a rebase?

saschagrunert avatar Oct 15 '20 18:10 saschagrunert