conmon icon indicating copy to clipboard operation
conmon copied to clipboard

logging: remove unuseful fsync

Open giuseppe opened this issue 1 year ago • 0 comments
trafficstars

the file is going to be removed few lines later with rename():

	/* Replace the previous file */
	if (rename(k8s_log_path_tmp, k8s_log_path) < 0) {
		pexit("Failed to rename log file");
	}

so there is no point in the expensive sync call since the file is not supposed to be persisted after a reboot.

giuseppe avatar Jul 04 '24 09:07 giuseppe