conmon Support `STATUS` sd

Support `STATUS` sd_notify

Open quentin9696 opened this issue 3 years ago • 5 comments

/kind feature

Description

Support sd_notify STATUS

Actually, podman 3.4.1 only support WATCHDOG and READY notification when using --sdnotify=container.

That would be interesting to integrate more messages, like STATUS

Dec 17 '21 01:12 quentin9696

Interested in opening a PR?

Dec 17 '21 10:12 rhatdan

No, because I'm not dev and I never touched Go.

Maybe with some indication on where to search in the code I can try.

Dec 17 '21 17:12 quentin9696

@vrothberg WDYT?

Dec 18 '21 11:12 rhatdan

Thanks for reaching out. This it outside of Podman's hands but something conmon had to support.

I'll transfer the issue.

Dec 20 '21 12:12 vrothberg

This is where we had to punch: https://github.com/containers/conmon/blob/main/src/conn_sock.c#L371-L383

@giuseppe WDYT?

Dec 20 '21 12:12 vrothberg

I just spend the whole day finding out, why this is not working, until I found this issue ;) Any chance this will be implemented?

Mar 14 '23 18:03 romge

@giuseppe WDYT?

Mar 15 '23 07:03 vrothberg

since more users are asking for it, I think at this point it is useful to have it.

Anyone would like to open a PR?

Mar 16 '23 08:03 giuseppe