containers
OCI-archive multi-manifest support POC
This is https://github.com/containers/image/pull/1677 + #921, updated to merge on top of current main, + an attempt to resolve review comments, and a fairly intrusive set of changes to actually implement pulling as expected.
Note that this depends on LoadManifestDescriptor being able to benefit from archive.Reader. Alternatively, we could introduce some other API with a similar effect (have NewReaderForReference directly return the manifest descriptor?)
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: mtrmac
Once this PR has been reviewed and has the lgtm label, please assign luap99 for approval by writing /assign @luap99 in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@mtrmac: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The feature is 80–90 % done, so abandoning it seems like a waste.
OTOH it has been a long time, and by now at least the c/image part requires a non-trivial rebase.
Now that @flouthoc is not with Red Hat any longer, do you still think we are going to go forward with this, rather then just changing the default to zstd:chunked?
@rhatdan This has no relationship to zstd (of any kind) at all.
I think it’s a useful feature, but features get added one at a time depending on priorities.