buildah icon indicating copy to clipboard operation
buildah copied to clipboard

test: do not untar archive into fs when checking file names

Open iTrooz opened this issue 1 month ago • 4 comments

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

In BATS tests, it avoids untar'ing archives into the filesystem when it is not needed. Instead, it uses tar -t to list the archive files instead.

As a bonus, it also fixes the test build with custom build output and output rootfs to tar, which does not check the output of the right command (it seems like it wanted to read the output of ls but it read the output of run_buildah

How to verify it

Run test suite

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

iTrooz avatar Nov 28 '25 23:11 iTrooz

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iTrooz Once this PR has been reviewed and has the lgtm label, please assign mheon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Nov 28 '25 23:11 openshift-ci[bot]

Ephemeral COPR build failed. @containers/packit-build please check.

Nice catch! The commit log subject line is longer than we generally expect, though, causing it to be wrapped in the commits tab of the pull request web page. LGTM with a tweak to the commit log.

nalind avatar Dec 02 '25 20:12 nalind

Done !

iTrooz avatar Dec 03 '25 08:12 iTrooz