buildah icon indicating copy to clipboard operation
buildah copied to clipboard

feat(build): print error on build flag --output=type=something

Open iTrooz opened this issue 1 month ago • 12 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

Two things:

  • make build flag --output=tar,dest=- have correct behaviour (streaming to stdout)
  • print error on build flag --output=type=something instead of outputting image to folder type=something (this is the case whether "something" is a valid type or not)

How to verify it

  • Run podman build . --output=tar,dest=-
  • Run podman build --output=type=something

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

make build flag `--output=tar,dest=-` have correct behaviour (streaming to stdout)
print error on build flag `--output=type=INVALID` instead of outputting image to folder `type=INVALID`

iTrooz avatar Nov 05 '25 16:11 iTrooz

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iTrooz Once this PR has been reviewed and has the lgtm label, please assign mheon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Nov 08 '25 20:11 openshift-ci[bot]

I updated the title with the most important change. Would you like me to split the PR into 2 instead ?

iTrooz avatar Nov 08 '25 20:11 iTrooz

Ephemeral COPR build failed. @containers/packit-build please check.

Ephemeral COPR build failed. @containers/packit-build please check.

Ephemeral COPR build failed. @containers/packit-build please check.

CI failed because of an image pull timeout. TestConformance/header-builtin succeeds locally. I think it should be re-run

iTrooz avatar Nov 08 '25 21:11 iTrooz

I'm having trouble figuring what's wrong in my PR. The errors seem unrelated to my PR, happening in files that I did not modify at all. Could I get some help please @nalind ? Thank you in advance

iTrooz avatar Nov 14 '25 10:11 iTrooz

The errors in the runc configurations are a known flake (#6205) that should be fixed in runc 1.3.2 or later, but our VM images don't include that yet, as prior to the recent round of security updates they probably had 1.3.0. The error on the testing farm looks like a transient network problem. I've restarted them and will keep an eye on them.

nalind avatar Nov 14 '25 16:11 nalind

All done ! I ran tests I modified/added locally

iTrooz avatar Nov 18 '25 13:11 iTrooz

Ok, CI is fully passing now !

iTrooz avatar Nov 26 '25 18:11 iTrooz

LGTM, thanks! @containers/buildah-maintainers PTAL

nalind avatar Dec 01 '25 22:12 nalind

Just fixed the commit length error :) Thanks for accepting

iTrooz avatar Dec 01 '25 22:12 iTrooz