buildah icon indicating copy to clipboard operation
buildah copied to clipboard

`manifest add`: prefer lists when looking up for `--all`

Open nalind opened this issue 2 months ago • 4 comments

What type of PR is this?

/kind bug

What this PR does / why we need it:

When looking up the image to add, if we were passed --all, set the flag that we pass to libimage to indicate that we prefer a list if there is one, so that it doesn't just hand us back one image from a list.

How to verify it

Updated test!

Which issue(s) this PR fixes:

Related to https://github.com/containers/podman/issues/27228.

Special notes for your reviewer:

Requires https://github.com/containers/container-libs/pull/382.

Does this PR introduce a user-facing change?

None

nalind avatar Oct 08 '25 21:10 nalind

All kinds of angry red tests @nalind

TomSweeneyRedHat avatar Oct 10 '25 19:10 TomSweeneyRedHat

The updated test won't pass without https://github.com/containers/container-libs/pull/382.

nalind avatar Oct 10 '25 19:10 nalind

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [flouthoc,nalind]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 17 '25 16:10 openshift-ci[bot]

A friendly reminder that this PR had no activity for 30 days.

github-actions[bot] avatar Nov 17 '25 00:11 github-actions[bot]