fix: add newline to digestfile
What type of PR is this?
/kind other
What this PR does / why we need it:
This PR adds newline to buildah push --digestfile output file.
How to verify it
buildah push --digestfile digest.txt
cat -A digest.txt
# Should contain $ symbol at the end of the digest
Which issue(s) this PR fixes:
Special notes for your reviewer:
Smoke test job fails on pr-should-include-tests script. Since this change is pretty minor I'm not sure if it need any additional testing.
Does this PR introduce a user-facing change?
Added newline to buildah push --digestfile output file.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: d3spairx Once this PR has been reviewed and has the lgtm label, please assign giuseppe for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
I always imagined --digestfile as a complement to --iidfile, and we don't include a newline at the end of those because docker build doesn't. What's the intent behind making this behave differently?
A friendly reminder that this PR had no activity for 30 days.
@nalind when we open digestfile in the terminal, we have broken terminal output because of the lack of newline. That is the whole intention of this PR.
A friendly reminder that this PR had no activity for 30 days.
@d3spairx tests need help, and it would probably be good to rebase this.