buildah icon indicating copy to clipboard operation
buildah copied to clipboard

tests: don't do so many internet requests

Open Luap99 opened this issue 8 months ago • 2 comments

Each network request increases the chances flakes, tests should always avoid making external requests as much as possible. Example failures observed in podman: https://api.cirrus-ci.com/v1/artifact/task/6035732734672896/html/bud-podman-fedora-42-root-host-sqlite.log.html

# STEP 6/7: ADD https://github.com/containers/buildah/blob/main/README.md /tmp/
# Error: building at STEP "ADD https://github.com/containers/buildah/blob/main/README.md /tmp/": reading "https://github.com/containers/buildah/blob/main/README.md": invalid response status 429

Unless there is some strong reason I suggest these tests should setup their own local websever to serve these contents so they don't have to reach out to servers we don't control.

Luap99 avatar May 06 '25 14:05 Luap99

Link https://github.blog/changelog/2025-05-08-updated-rate-limits-for-unauthenticated-requests/

I think we really cannot use so many direct github requests here as this will keep causing flakes. (I see quite a lot on podman buildah bud tests) @nalind @flouthoc Any reason that the tests are using github? Can we setup our own local web server on localhost the serves static content in the tests instead? I know there are some tests for git clone and the likes those could maybe be converted to a local git repo setup?

This might be something @timcoding1988 could work on.

Luap99 avatar May 15 '25 11:05 Luap99

A friendly reminder that this issue had no activity for 30 days.

github-actions[bot] avatar Jun 15 '25 00:06 github-actions[bot]