buildah
buildah copied to clipboard
Vendor in latest containers/storage
What type of PR is this?
/kind api-change /kind bug /kind cleanup /kind deprecation /kind design /kind documentation /kind failing-test /kind feature /kind flake /kind other
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Ephemeral COPR build failed. @containers/packit-build please check.
@giuseppe The pigz change has changed one of the tests when running out of space on disk.
[+2438s] # Error: writing blob: storing blob to file "/var/tmp/buildah_tests.fhmvnh/buildah-test/container_images_storage3753737850/2": pigz: skipping:
Where currently Buildah test is looking for:
@test "pull image with TMPDIR set" {
skip_if_rootless_environment
testdir=${TEST_SCRATCH_DIR}/buildah-test
mkdir -p $testdir
mount -t tmpfs -o size=1M tmpfs $testdir
TMPDIR=$testdir run_buildah 125 pull --policy always $WITH_POLICY_JSON quay.io/libpod/alpine_nginx:latest
expect_output --substring "no space left on device"
run_buildah pull --policy always $WITH_POLICY_JSON quay.io/libpod/alpine_nginx:latest
umount $testdir
rm -rf $testdir
}
We can simply fix the tests, but the error message from pigz kinda stinks.
this should help: https://github.com/containers/storage/pull/2012
@giuseppe @mtrmac @cgwalters PTAL The fix by Giuseppe got the test to pass.
@flouthoc @giuseppe @nalind @mheon @ashley-cui @vrothberg PTAL Can we get this merged, so we can finally update podman.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: giuseppe, rhatdan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [giuseppe,rhatdan]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment