buildah icon indicating copy to clipboard operation
buildah copied to clipboard

Vendor in latest containers/storage

Open rhatdan opened this issue 1 year ago • 3 comments
trafficstars

What type of PR is this?

/kind api-change /kind bug /kind cleanup /kind deprecation /kind design /kind documentation /kind failing-test /kind feature /kind flake /kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?


rhatdan avatar Jun 11 '24 20:06 rhatdan

Ephemeral COPR build failed. @containers/packit-build please check.

@giuseppe The pigz change has changed one of the tests when running out of space on disk.

[+2438s] # Error: writing blob: storing blob to file "/var/tmp/buildah_tests.fhmvnh/buildah-test/container_images_storage3753737850/2": pigz: skipping: : corrupted -- incomplete deflate data: exit status 1

Where currently Buildah test is looking for:

@test "pull image with TMPDIR set" {
  skip_if_rootless_environment
  testdir=${TEST_SCRATCH_DIR}/buildah-test
  mkdir -p $testdir
  mount -t tmpfs -o size=1M tmpfs $testdir

  TMPDIR=$testdir run_buildah 125 pull --policy always $WITH_POLICY_JSON quay.io/libpod/alpine_nginx:latest
  expect_output --substring "no space left on device"

  run_buildah pull --policy always $WITH_POLICY_JSON quay.io/libpod/alpine_nginx:latest
  umount $testdir
  rm -rf $testdir
}

We can simply fix the tests, but the error message from pigz kinda stinks.

rhatdan avatar Jul 11 '24 10:07 rhatdan

this should help: https://github.com/containers/storage/pull/2012

giuseppe avatar Jul 11 '24 12:07 giuseppe

@giuseppe @mtrmac @cgwalters PTAL The fix by Giuseppe got the test to pass.

rhatdan avatar Jul 12 '24 19:07 rhatdan

@flouthoc @giuseppe @nalind @mheon @ashley-cui @vrothberg PTAL Can we get this merged, so we can finally update podman.

rhatdan avatar Jul 15 '24 09:07 rhatdan

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [giuseppe,rhatdan]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jul 15 '24 11:07 openshift-ci[bot]