buildah icon indicating copy to clipboard operation
buildah copied to clipboard

Published 20 hours ago • verified publisher icon containers

libsubid tag not added

Open shaba opened this issue 1 year ago • 3 comments

Many Linux OS have gcc with -Wl,--as-needed as default. hack/libsubid_tag.sh not ready for --as-needed and libsubid tag not added to STORAGETAGS in Makefile.

"cc -o "$tmpdir"/libsubid_tag -l subid -x c foo.c" should be "cc foo.c -o "$tmpdir"/libsubid_tag -l subid -x c " for --as-needed or add -Wl,--no-as-needed flag.

shaba avatar Dec 11 '23 12:12 shaba

Care to open a PR to fix the way you like?

rhatdan avatar Dec 11 '23 12:12 rhatdan

Fix like this https://github.com/containers/podman/commit/8ff54cbe8cfe37744f773a6096e6f7413419bb6d

shaba avatar Dec 11 '23 13:12 shaba

SGTM, please open a PR?

rhatdan avatar Dec 13 '23 11:12 rhatdan