buildah icon indicating copy to clipboard operation
buildah copied to clipboard

[WIP] default to zstd:chunked

Open rhatdan opened this issue 7 months ago • 5 comments

[NO NEW TESTS NEEDED]

What type of PR is this?

/kind api-change /kind bug /kind cleanup /kind deprecation /kind design /kind documentation /kind failing-test /kind feature /kind flake /kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

rhatdan avatar Nov 09 '23 20:11 rhatdan

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Nov 09 '23 20:11 openshift-ci[bot]

@giuseppe Is the failure here the one you have been working with @mtrmac on?

Looks like buildah is pulling an image when it has it in cache?

rhatdan avatar Nov 12 '23 12:11 rhatdan

yes that is one of the issues that containers/image#1980 is addressing

giuseppe avatar Nov 13 '23 14:11 giuseppe

Should we move to tests everything with zstd:chunked at this point? I think it is time to turn this on in testing to make sure everything works going forward.

rhatdan avatar Mar 20 '24 15:03 rhatdan

Repeated zstd:chunked pushes are still known to be inefficient. I don’t think that’s exactly a blocker to switching tests to zstd:chunked, but unless we are going to institute some kind of matrix where various option values are tested simultaneously, I think testing the most production-relevant values is more valuable.

mtrmac avatar Mar 20 '24 16:03 mtrmac

Except the goal is to change the default in Fedora 41 to zstd:chunked. I have already changed the default in Rawhide, to move this forward. If we continue to default to gzip, we will never get to zstd:chunked.

rhatdan avatar Mar 27 '24 11:03 rhatdan