Support for ADD <git ref> in Containerfile

[dustymabe]

It seems Dockerfile supports adding a git repo files via:

ADD [--keep-git-dir=<boolean>] <git ref> <dir>

https://docs.docker.com/engine/reference/builder/#adding-a-git-repository-add-git-ref-dir

Do we support that? Can we support that?

[flouthoc]

@dustymabe Thanks for creating the issue.

Do we support that?

Afaik No, buildah supports adding contents from remote URL but it does not treats git or git ref as a special case. @nalind Could you confirm please.

Can we support that ?

Sure this can be implemented.

[nalind]

ADD doesn't do any special handling for what look like Git repository locations, no.

[rhatdan]

If docker supports it, so should we.

[danishprakash]

Mind If I take a look at this?

[rhatdan]

SGTM

[github-actions[bot]]

A friendly reminder that this issue had no activity for 30 days.

[rhatdan]

@danishprakash any progress?

[danishprakash]

Not yet, I'll take a look at it end of next week.

[github-actions[bot]]

A friendly reminder that this issue had no activity for 30 days.

[jfroy]

I might take a stab at this if @danishprakash has more important stuff to do.

[rhatdan]

After 30 days it is up for grabs. go for it.

[douglascamata]

Would love to see this feature make it to buildah and eventually podman. Docker's been supporting it since a while and it's not under any sort of experimental flag.

[douglascamata]

In the mean time, do any of you have a suggested workaround that's not going to mess up image layer caching (like git clone) and stays within the Dockerfile?

[rhatdan]

@jfroy did you ever get a chance to work on it?

[jfroy]

Not yet, haven't had the time.

[rhatdan]

I think most of the code is in something like:

path, subdir, err := define.TempDirForURL(tmpdir.GetTempDir(), internal.BuildahExternalArtifactsDir, src)

[danishprakash]

I can start looking at it now, is this still open?

[jfroy]

I can start looking at it now, is this still open?

Yep, I haven't started! Take it.