buildah icon indicating copy to clipboard operation
buildah copied to clipboard

distributedCache: allow local `dir://` and `container-storage://` as a cache transport

Open flouthoc opened this issue 1 year ago • 6 comments

Allowing local directory as transport enables users to make distributed caching more flexible by making sure.

  • Allows end users to move cache sources and destination manually.
  • Allows storing cache on an NFS or various mount sources.
  • Allows end users to distribute cache without registry setup.

[NO NEW TESTS NEEDED] [NO TESTS NEEDED] // Will add test in final commit

What type of PR is this?

/kind api-change /kind bug /kind cleanup /kind deprecation /kind design /kind documentation /kind failing-test /kind feature /kind flake /kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

distributedCache: allow local `dir://` and `container-storage://` as a cache transport

Closes: https://github.com/containers/buildah/issues/4875

flouthoc avatar Jun 26 '23 08:06 flouthoc

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jun 26 '23 08:06 openshift-ci[bot]

@nalind PTAL My concern here is you are breaking API.

rhatdan avatar Jun 26 '23 11:06 rhatdan

A friendly reminder that this PR had no activity for 30 days.

github-actions[bot] avatar Jul 27 '23 00:07 github-actions[bot]

Is this a breaking change? @vrothberg @mtrmac PTAL

rhatdan avatar Jul 28 '23 12:07 rhatdan

A friendly reminder that this PR had no activity for 30 days.

github-actions[bot] avatar Aug 28 '23 00:08 github-actions[bot]

Closing as this has not been touched in 6 months.

rhatdan avatar Jan 31 '24 19:01 rhatdan