containers
"acbuild" features overlap with "actool patch-manifest"
The command actool patch-manifest has some features that overlap with acbuild:
https://github.com/appc/spec/blob/master/actool/manifest.go#L56
- [x]
--manifest=MANIFEST_FILE - [x]
--name=example.com/app(acbuild set-name ACI_NAME) - [x]
--exec="/app --debug"(acbuild set-exec CMD) - [x]
--user=uid(acbuild set-user USER) - [x]
--group=gid(acbuild set-group GROUP) - [ ]
--capability=CAP_SYS_ADMIN,CAP_NET_ADMIN - [x]
--mounts=work,path=/opt,readOnly=true[:work2,...](acbuild mount add NAME PATH) - [x]
--ports=query,protocol=tcp,port=8080[:query2,...](acbuild port add NAME PROTOCOL PORT) - [ ]
--supplementary-groups=gid1,gid2,... - [ ]
--isolators=resource/cpu,request=50m,limit=100m[:resource/memory,...]
Should actool get the missing features and then actool patch-manifest be deprecated?
@alban That is what I had been thinking, see https://github.com/appc/acbuild/blob/master/README.md#related-work
Do you have any concerns about this?
No real concern. At the moment, rkt functional tests use actool patch-manifest with options like --supplementary-groups= and --manifest=file that do not exist in acbuild yet. If we switch to acbuild, we just need to make sure it covers the needed features.
Sure. With my experiences trying to get actool vendored properly with go1.5, I'm starting to think we should instead vendor acbuild/lib and use that programmatically instead...
On Tue, Oct 13, 2015 at 1:28 AM, Alban Crequy [email protected] wrote:
No real concern. At the moment, rkt functional tests use actool patch-manifest with options like --supplementary-groups= and --manifest=file that do not exist in acbuild yet. If we switch to acbuild, we just need to make sure it covers the needed features.
— Reply to this email directly or view it on GitHub https://github.com/appc/acbuild/issues/31#issuecomment-147646540.