bubblewrap icon indicating copy to clipboard operation
bubblewrap copied to clipboard

Make "--unshare-user-try" check if /proc is mounted with hidepid

Open madaidan opened this issue 6 years ago • 3 comments

This is a workaround for https://github.com/containers/bubblewrap/issues/198

It checks if /proc/mounts contains anything related to hidepid.

I'm very new to C so sorry if there's anything wrong. It worked fine when testing.

madaidan avatar Oct 10 '19 22:10 madaidan

Can one of the admins verify this patch? I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

rh-atomic-bot avatar Oct 10 '19 22:10 rh-atomic-bot

That is a very very rough way of detecting the flags (string compare over entire file). There is some mountinfo parsing in bind-mount.c, i think using that for this would make more sense.

alexlarsson avatar Oct 11 '19 10:10 alexlarsson

It is very rough but I don't know how else to detect the flags.

madaidan avatar Oct 11 '19 13:10 madaidan