bubblewrap icon indicating copy to clipboard operation
bubblewrap copied to clipboard

Published 20 hours ago • verified publisher icon containers

make configure.ac more m4'onic

Open tharvik opened this issue 6 years ago • 1 comments
trafficstars

M4sh differs from the standard sh syntax by using AS_IF and AS_CASE, it is used to know when to initialize pkg-config for example. Here, some code are using the classic sh syntax, thus, autoconf is unable to know that it is a conditional and fail to generate correctly. This PR fixes that by using the correct macros and allow --with-bash-completion-dir=... --enable-selinux to work. It also simplified some branching.

tharvik avatar May 12 '19 14:05 tharvik

Can one of the admins verify this patch? I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

rh-atomic-bot avatar May 12 '19 14:05 rh-atomic-bot

I've merged #441 which basically did the same thing as the non-behaviour-changing parts of this.

smcv avatar Oct 27 '22 16:10 smcv

(Also, consider using the new Meson build system, available since 0.6.0, which avoids Autotools quirks by not being Autotools; the Autotools build system will probably be removed at some point.)

smcv avatar Oct 27 '22 19:10 smcv