bootc icon indicating copy to clipboard operation
bootc copied to clipboard

restricting main branch to "[ ] Require pull request before merging" is being reverted

Open cgwalters opened this issue 2 years ago • 10 comments

I want to make reviews required by default on this project (as they should be on most).

I can make the change successfully in the web UI, but it seems like something is reverting it later. Is there some automation on the containers/ GH org that is doing something like this?

cgwalters avatar Feb 05 '23 13:02 cgwalters

cc @baude @cevich - any ideas?

cgwalters avatar Feb 05 '23 13:02 cgwalters

I am not aware of anything being set. If it is, it is likely an accident.

baude avatar Feb 05 '23 16:02 baude

I too am unaware, didn't even know overriding it at the org-level was possible (is it?).

cevich avatar Feb 06 '23 20:02 cevich

Just looked through all the org-level settings and didn't find anything that would change settings like that. Hmmm. We do have 10-something apps setup on the org., it's entirely possible one is responsible but none jump out at me. I'll take the list to the team and see which ones we can disable/remove.

cevich avatar Feb 06 '23 20:02 cevich

Thanks Chris. Whatever is reverting it seems to be running on a roughly daily schedule. The setting lasted for hours at least last time I tried it.

cgwalters avatar Feb 06 '23 21:02 cgwalters

Ah, the audit log makes it very obvious:

image

Will try to talk to the Prow team to see how to fix that.

cgwalters avatar Feb 06 '23 21:02 cgwalters

Semi-blindly trying https://github.com/openshift/release/pull/36102

cgwalters avatar Feb 06 '23 21:02 cgwalters

@baude not urgent but https://github.com/openshift/release/pull/36102#issuecomment-1419893277 when you get a chance

cgwalters avatar Feb 06 '23 22:02 cgwalters

@cevich is it the case today that all the other repositories in the containers org that have Prow jobs also use Prow to merge (i.e. with approve/lgtm + tide)?

cgwalters avatar Feb 15 '24 13:02 cgwalters

Unfortunately no, not all 100-some odd repos, Red Hat doesn't maintain all of them. Off-hand, it's about 15-20 repos that use Prow.

cevich avatar Feb 15 '24 20:02 cevich

@cgwalters, did you resolve the issue in the meantime?

vrothberg avatar May 31 '24 11:05 vrothberg

Yes, we dropped Prow for now

cgwalters avatar May 31 '24 12:05 cgwalters