ansible-podman-collections icon indicating copy to clipboard operation
ansible-podman-collections copied to clipboard

generate_systemd: implement --wants, --after and --requires (GH-431)

Open d-513 opened this issue 2 years ago • 3 comments

This adds --after, --wants and --requires support to generate_systemd modules.

Closes #431

Signed-off-by: dada513 [email protected]

d-513 avatar May 28 '22 16:05 d-513

Great, thanks! Would you like to add it to test here as well? https://github.com/containers/ansible-podman-collections/blob/master/tests/integration/targets/podman_container/tasks/main.yml#L546-L576

sshnaidm avatar Jun 06 '22 09:06 sshnaidm

Please fix a couple of pep8 issues:

ERROR: Found 2 pep8 issue(s) which need to be resolved:
ERROR: plugins/modules/podman_container.py:366:134: W291: trailing whitespace
ERROR: plugins/modules/podman_pod.py:171:134: W291: trailing whitespace

sshnaidm avatar Jun 06 '22 09:06 sshnaidm

Sure, I'll try to get those sorted asap. Also I will add it to the tests

d-513 avatar Jun 06 '22 11:06 d-513

check-github

sshnaidm avatar Aug 31 '22 21:08 sshnaidm

check-github

sshnaidm avatar Sep 01 '22 07:09 sshnaidm

check-github

sshnaidm avatar Sep 01 '22 13:09 sshnaidm