aardvark-dns
aardvark-dns copied to clipboard
containers
coredns: response message always set recursion available (`RA`) when `RD` is set in request
Set recursion available in all response message by setting RA flag in
response packet.
Closes: https://github.com/containers/aardvark-dns/issues/204
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: flouthoc
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [flouthoc]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
/hold need to verify if we should check RD (Recursion Desired) flag in the request packet and not always set RA.
PR should be good but lets wait for https://github.com/containers/aardvark-dns/pull/208
CI seems broken, but it doesn't look like your PR; could be a more general thing?
@cevich Looks like the new VM is missing configured rust stable, could it happen cause we update the VM.
could it happen cause we update the VM.
Most probably. Here's what happes at image-build time:
https://github.com/containers/automation_images/blob/main/cache_images/fedora-netavark_packaging.sh#L72-L76
So if I understand correctly, we need to add 'default' to the end of that? Better yet, since y'all probably know better than I, just open up a PR in that repo. to fix it. It will build new images in about an hour that you can then test in this PR.
