contain-google icon indicating copy to clipboard operation
contain-google copied to clipboard

Whitelist some sites for the container

Open tlaundal opened this issue 5 years ago • 4 comments

When logging into my google account with OneLogin, the login process hangs if I have this extension enabled.

My workaround is this:

  • Open gmail in the google container - it will be logged out
  • Disable the extension
  • Login to gmail in the container with OneLogin - OneLogin is now open inside the container
  • Gmail logs in and is still in the container
  • Enable the extension

I believe this process could be streamlined by allowing the onelogin domain to stay in the container when opened from the container. I believe the risk involved in this is very low.

I do not think OneLogin should be hard coded in the application, but that we rather should accept a whitelist of domains that are allowed to stay inside the container from settings.

I can create a PR for this in a while.

tlaundal avatar Jun 19 '19 10:06 tlaundal

I think there is no need for whitelist. We can make it works by defining some oauth related paths that need to be available to perform such login. Make it an option just like Ignore Youtube.

herpiko avatar Jun 23 '19 17:06 herpiko

I do not believe your PR will fix this issue, as this relates to logging into Google with SSO. As for the whitelist: I believe it makes more sense to let a few third party sites into the google container, than to let a few google URI out of the container.

tlaundal avatar Jun 23 '19 19:06 tlaundal

Totally agree with @tlaundal . Here an issue asking for the same #113

situplastik avatar Jan 11 '21 11:01 situplastik

PR #114 resolve that problem @Perflyst

situplastik avatar Mar 04 '21 07:03 situplastik